Minor improvements and fixes - Githubissues

configcat / .net-sdk

ConfigCat SDK for .NET. ConfigCat is a hosted feature flag service: https://configcat.com. Manage feature toggles across frontend, backend, mobile, desktop apps. Alternative to LaunchDarkly. Management app + feature flag SDKs.

https://configcat.com/docs/sdk-reference/csharp

Other

29 stars 8 forks source link

Minor improvements and fixes #74

Closed adams85 closed 1 year ago

adams85 commented 1 year ago

Describe the purpose of your pull request

Improvements:

Simplify IRolloutEvaluator.Evaluate and eliminate EvaluationDetailsFactory.

Bug fixes:

Add missing unsupported value check when evaluating multiple settings.
Fix return value of GetAllValues/GetAllValuesAsync when one or more settings evaluate with error.

Related issues (only if applicable)

Provide links to issues relating to this pull request

Requirement checklist (only if applicable)

[x] I have covered the applied changes with automated tests.
[x] I have executed the full automated test set against my changes.
[x] I have validated my changes against all supported platform versions.
[x] I have read and accepted the contribution agreement.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

98.6% Coverage
0.0% Duplication