Closed adams85 closed 9 months ago
Some benchmark results to support the arguments made for the current implementation.
Method | Runtime | LogInfo | Mean | Error | StdDev | Ratio | RatioSD | Gen0 | Gen1 | Allocated | Alloc Ratio |
---|---|---|---|---|---|---|---|---|---|---|---|
MatrixTests_ConfigV5 | .NET 6.0 | False | 25.92 ms | 2.274 ms | 0.125 ms | 1.00 | 0.00 | 2406.2500 | - | 38.88 MB | 1.00 |
MatrixTests_ConfigV5 | .NET Framework 4.8 | False | 56.24 ms | 16.932 ms | 0.928 ms | 2.17 | 0.05 | 7111.1111 | - | 43.08 MB | 1.11 |
MatrixTests_ConfigV6 | .NET 6.0 | False | 11.17 ms | 2.751 ms | 0.151 ms | 1.00 | 0.00 | 859.3750 | - | 13.94 MB | 1.00 |
MatrixTests_ConfigV6 | .NET Framework 4.8 | False | 29.70 ms | 4.885 ms | 0.268 ms | 2.66 | 0.01 | 3218.7500 | - | 19.36 MB | 1.39 |
MatrixTests_ConfigV5 | .NET 6.0 | True | 25.64 ms | 3.050 ms | 0.167 ms | 1.00 | 0.00 | 2406.2500 | - | 38.88 MB | 1.00 |
MatrixTests_ConfigV5 | .NET Framework 4.8 | True | 56.09 ms | 1.123 ms | 0.062 ms | 2.19 | 0.02 | 7111.1111 | - | 43.08 MB | 1.11 |
MatrixTests_ConfigV6 | .NET 6.0 | True | 28.51 ms | 0.423 ms | 0.023 ms | 1.00 | 0.00 | 3937.5000 | 31.2500 | 62.83 MB | 1.00 |
MatrixTests_ConfigV6 | .NET Framework 4.8 | True | 69.74 ms | 9.644 ms | 0.529 ms | 2.45 | 0.02 | 12875.0000 | 125.0000 | 77.4 MB | 1.23 |
@configcat/ux-qa-team May I also request a review from UX perspective for this PR? More specifically, for the XML comments of the source files located under src/ConfigCatClient/Models
.
@adams85 Who sees those comments in what situation?
Developers will see them in their IDE, in Intellisense popups.
Thanks, seems like this is pretty big, adding it to the UX board and will prioritize tomorrow morning.
Kudos, SonarCloud Quality Gate passed!
Describe the purpose of your pull request
Implements config v6 support.
Features/improvements:
config_v6.json
) and update config modelEvaluationDetails.MatchedTargetingRule
/MatchedPercentageOption
properties (rename + set combinations correctly)Tests:
EvaluationDetails.MatchedTargetingRule
/MatchedPercentageOption
properties (rename + set combinations correctly)Related improvements/fixes:
Breaking changes:
MatchedEvaluationRule
property toMatchedTargetingRule
and theMatchedEvaluationPercentageRule
property toMatchedPercentageOption
inEvaluationDetails
.IConfig
and related interfaces/enums).User.Custom
to disallow null values.User.AllAttributes
property into a method (GetAllAttributes
) as it allocates under the hood.Requirement checklist (only if applicable)