Fix subtle memory leak issue

configcat / .net-sdk

ConfigCat SDK for .NET. ConfigCat is a hosted feature flag service: https://configcat.com. Manage feature toggles across frontend, backend, mobile, desktop apps. Alternative to LaunchDarkly. Management app + feature flag SDKs.

https://configcat.com/docs/sdk-reference/csharp

Other

29 stars 8 forks source link

Fix subtle memory leak issue #82

Closed adams85 closed 9 months ago

adams85 commented 10 months ago

Describe the purpose of your pull request

A hook event handler which closes over the client instance should not prevent the client from being collected by the GC when user has no more references to the client.

Requirement checklist (only if applicable)

[x] I have covered the applied changes with automated tests.
[x] I have executed the full automated test set against my changes.
[x] I have validated my changes against all supported platform versions.
[x] I have read and accepted the contribution agreement.

sonarcloud[bot] commented 10 months ago

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

98.4% Coverage
6.7% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint