adams85 commented 1 year ago

Describe the purpose of your pull request

Adjusts implementation to match the upcoming configcat-common major version, including a complete revision of the HttpConfigFetcher class.
Re-exports public API types so consumers can avoid adding configcat-common as a dependency to their projects.
Updates tests and samples

Also, revises the test runner (karma) configuration because package resolution in karma-typescript seems kind of broken, which blocks using/upgrading to newer packages (e.g. mocha 9.0.0+ or mock-xmlhttprequest 8.0.0+):

Replaces karma-typescript with karma-webpack (which has the additional benefit of allowing us to test the code which we actually distribute).
Configures source map for useful stack traces in the case of failing tests.

Requirement checklist (only if applicable)

[x] I have covered the applied changes with automated tests.
[x] I have executed the full automated test set against my changes.
[x] I have validated my changes against all supported platform versions.
[x] I have read and accepted the contribution agreement.

codecov[bot] commented 1 year ago

Codecov Report

Base: 95.37% // Head: 84.90% // Decreases project coverage by -10.47% :warning:

Coverage data is based on head (d544e78) compared to base (1422b7d). Patch coverage: 76.47% of modified lines in pull request are covered.

:exclamation: Current head d544e78 differs from pull request most recent head d4425ea. Consider uploading reports for the commit d4425ea to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #53 +/- ## =========================================== - Coverage 95.37% 84.90% -10.48% =========================================== Files 6 3 -3 Lines 346 53 -293 Branches 15 10 -5 =========================================== - Hits 330 45 -285 + Misses 11 4 -7 + Partials 5 4 -1 ``` | [Impacted Files](https://codecov.io/gh/configcat/js-ssr-sdk/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat) | Coverage Δ | | |---|---|---| | [src/index.ts](https://codecov.io/gh/configcat/js-ssr-sdk/pull/53/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat#diff-c3JjL2luZGV4LnRz) | `75.00% <50.00%> (-19.45%)` | :arrow_down: | | [src/ConfigFetcher.ts](https://codecov.io/gh/configcat/js-ssr-sdk/pull/53/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat#diff-c3JjL0NvbmZpZ0ZldGNoZXIudHM=) | `80.00% <78.26%> (+33.84%)` | :arrow_up: | | [src/Cache.ts](https://codecov.io/gh/configcat/js-ssr-sdk/pull/53/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat#diff-c3JjL0NhY2hlLnRz) | `95.00% <85.71%> (+0.26%)` | :arrow_up: | | [test/IndexTests.ts](https://codecov.io/gh/configcat/js-ssr-sdk/pull/53/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat#diff-dGVzdC9JbmRleFRlc3RzLnRz) | | | | [test/IntegrationTests.ts](https://codecov.io/gh/configcat/js-ssr-sdk/pull/53/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat#diff-dGVzdC9JbnRlZ3JhdGlvblRlc3RzLnRz) | | | | [src/Version.ts](https://codecov.io/gh/configcat/js-ssr-sdk/pull/53/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat#diff-c3JjL1ZlcnNpb24udHM=) | | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.