configcat / js-ssr-sdk

ConfigCat SDK for JavaScript Server Side Rendered applications like NuxtJS. ConfigCat is a hosted feature flag service: https://configcat.com. Manage feature toggles across frontend, backend, mobile, desktop apps. Alternative to LaunchDarkly. Management app + feature flag SDKs.
https://configcat.com/docs/sdk-reference/js-ssr
MIT License
12 stars 6 forks source link

Minor improvements #78

Closed adams85 closed 9 months ago

adams85 commented 9 months ago

Describe the purpose of your pull request

Besides some minor perf/code quality improvements, makes changes to the implementation of LocalStorageCache:

Also:

Related issues (only if applicable)

Requirement checklist (only if applicable)

codecov[bot] commented 9 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b3dd995) 85.41% compared to head (1e83801) 85.93%.

Files Patch % Lines
src/ConfigFetcher.ts 60.00% 1 Missing and 1 partial :warning:
src/Cache.ts 96.42% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #78 +/- ## ========================================== + Coverage 85.41% 85.93% +0.52% ========================================== Files 3 3 Lines 48 64 +16 Branches 8 12 +4 ========================================== + Hits 41 55 +14 - Misses 4 6 +2 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.9% Duplication on New Code

See analysis details on SonarCloud