configcat / node-sdk

ConfigCat SDK for Node.js. ConfigCat is a hosted feature flag service: https://configcat.com. Manage feature toggles across frontend, backend, mobile, desktop apps. Alternative to LaunchDarkly. Management app + feature flag SDKs.
https://configcat.com/docs/sdk-reference/node
MIT License
19 stars 7 forks source link

Remove X-ConfigCat-UserAgent header #44

Closed z4kn4fein closed 2 years ago

z4kn4fein commented 2 years ago

Describe the purpose of your pull request

This PR removes the X-ConfigCat-UserAgent request header. The SDK version is now a query param in the fetch URL.

Requirement checklist (only if applicable)

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Merging #44 (6c8e6b6) into master (a755136) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 6c8e6b6 differs from pull request most recent head d67d6b4. Consider uploading reports for the commit d67d6b4 to get more accurate results

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   78.57%   78.57%           
=======================================
  Files           3        3           
  Lines          56       56           
  Branches       10       10           
=======================================
  Hits           44       44           
  Misses         12       12           
Impacted Files Coverage Δ
src/config-fetcher.ts 67.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a755136...d67d6b4. Read the comment docs.