configcat / node-sdk

ConfigCat SDK for Node.js. ConfigCat is a hosted feature flag service: https://configcat.com. Manage feature toggles across frontend, backend, mobile, desktop apps. Alternative to LaunchDarkly. Management app + feature flag SDKs.
https://configcat.com/docs/sdk-reference/node
MIT License
19 stars 7 forks source link

Replace got with built-in http/https node module #46

Closed z4kn4fein closed 2 years ago

z4kn4fein commented 2 years ago

Describe the purpose of your pull request

This PR replaces got with a http/https node module based HTTP handler.

Related issues (only if applicable)

45 #33

Requirement checklist (only if applicable)

codecov[bot] commented 2 years ago

Codecov Report

Merging #46 (d708b7b) into master (10cbdee) will increase coverage by 16.81%. The diff coverage is 91.17%.

:exclamation: Current head d708b7b differs from pull request most recent head c2edad1. Consider uploading reports for the commit c2edad1 to get more accurate results

@@             Coverage Diff             @@
##           master      #46       +/-   ##
===========================================
+ Coverage   78.57%   95.38%   +16.81%     
===========================================
  Files           3        3               
  Lines          56       65        +9     
  Branches       10       11        +1     
===========================================
+ Hits           44       62       +18     
+ Misses         12        3        -9     
Impacted Files Coverage Δ
src/config-fetcher.ts 93.47% <91.17%> (+25.91%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10cbdee...c2edad1. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication