configcat / node-sdk

ConfigCat SDK for Node.js. ConfigCat is a hosted feature flag service: https://configcat.com. Manage feature toggles across frontend, backend, mobile, desktop apps. Alternative to LaunchDarkly. Management app + feature flag SDKs.
https://configcat.com/docs/sdk-reference/node
MIT License
19 stars 7 forks source link

Nodeversion #54

Closed laliconfigcat closed 1 year ago

laliconfigcat commented 1 year ago

Describe the purpose of your pull request

Specifying Node.JS version with engine-strict=true and adding a badge with the supported SDK version.

Related issues (only if applicable)

Provide links to issues relating to this pull request

Requirement checklist (only if applicable)

codecov[bot] commented 1 year ago

Codecov Report

Base: 91.13% // Head: 91.13% // No change to project coverage :thumbsup:

Coverage data is based on head (f265a12) compared to base (9a980f5). Patch has no changes to coverable lines.

:exclamation: Current head f265a12 differs from pull request most recent head b442d05. Consider uploading reports for the commit b442d05 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #54 +/- ## ======================================= Coverage 91.13% 91.13% ======================================= Files 3 3 Lines 79 79 Branches 8 8 ======================================= Hits 72 72 Misses 7 7 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

adams85 commented 1 year ago

LGTM but please don't merge this before https://github.com/configcat/node-sdk/pull/55 to avoid massive merge conflicts.