configcat / node-sdk

ConfigCat SDK for Node.js. ConfigCat is a hosted feature flag service: https://configcat.com. Manage feature toggles across frontend, backend, mobile, desktop apps. Alternative to LaunchDarkly. Management app + feature flag SDKs.
https://configcat.com/docs/sdk-reference/node
MIT License
19 stars 7 forks source link

Adjust SDK to configcat-common v8.0 #58

Closed adams85 closed 1 year ago

adams85 commented 1 year ago

Describe the purpose of your pull request

Removes deprecated code.

Breaking changes:

Requirement checklist (only if applicable)

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
5.5% 5.5% Duplication

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
4.8% 4.8% Duplication

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.87 :warning:

Comparison is base (9dfc764) 91.13% compared to head (f90e456) 90.27%.

:exclamation: Current head f90e456 differs from pull request most recent head 913070f. Consider uploading reports for the commit 913070f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #58 +/- ## ========================================== - Coverage 91.13% 90.27% -0.87% ========================================== Files 3 3 Lines 79 72 -7 Branches 9 9 ========================================== - Hits 72 65 -7 Misses 7 7 ``` | [Impacted Files](https://app.codecov.io/gh/configcat/node-sdk/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat) | Coverage Δ | | |---|---|---| | [src/config-fetcher.ts](https://app.codecov.io/gh/configcat/node-sdk/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat#diff-c3JjL2NvbmZpZy1mZXRjaGVyLnRz) | `88.00% <50.00%> (ø)` | | | [src/client.ts](https://app.codecov.io/gh/configcat/node-sdk/pull/58?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat#diff-c3JjL2NsaWVudC50cw==) | `95.23% <100.00%> (-1.20%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.