search

configcat / node-sdk

ConfigCat SDK for Node.js. ConfigCat is a hosted feature flag service: https://configcat.com. Manage feature toggles across frontend, backend, mobile, desktop apps. Alternative to LaunchDarkly. Management app + feature flag SDKs.
https://configcat.com/docs/sdk-reference/node
MIT License
19 stars 7 forks source link

Proxy support #7

Closed ziofat closed 4 years ago

ziofat commented 5 years ago

Hi, my service are running behind a firewall which require a proxy to access configure file. Node SDK seems not able to send request over proxy.

mr-sige commented 5 years ago

Hi there, Adding proxy support to our SDKs is on our roadmap for this year. We have already implemented it in the .NET SDK: Repo: https://github.com/configcat/.net-sdk Related docs: https://configcat.com/docs/sdk-reference/csharp/#using-configcat-behind-a-proxy

Also we welcome contributions and happy to help and provide all the necessary info to do that.

ziofat commented 4 years ago

That will be hard to implement proxy support with ky as http client. The ky's author has another package called got for nodejs which has proxy support. Is that OK for you to replace ky with another http client?

mr-sige commented 4 years ago

I don't see a reason why not. I have added ky to support SSR (server side rendering) applications and Node in the same time. If got fulfills this as well then it is OK to replace.

ziofat commented 4 years ago

I am not sure got can support SSR or not. It might do if not using Stream related functions. I will try to make a PR and let you test with it.

configcat commented 4 years ago

Thanks for the PR. :) It will take some time for us to test if it works well in all usecases.