search

configcat / node-sdk

ConfigCat SDK for Node.js. ConfigCat is a hosted feature flag service: https://configcat.com. Manage feature toggles across frontend, backend, mobile, desktop apps. Alternative to LaunchDarkly. Management app + feature flag SDKs.
https://configcat.com/docs/sdk-reference/node
MIT License
19 stars 7 forks source link

add proxy support with got and node-tunnel #8

Closed ziofat closed 4 years ago

ziofat commented 4 years ago

I replaced ky with got and using tunnel package to create an agent as proxy. It should resolve #7

configcat commented 4 years ago

@ziofat The build fails when runing npm install then npm run build. Can you check on your end? Am I missing something?

ziofat commented 4 years ago

Maybe you should check https://github.com/configcat/common-js/pull/3 first, as it introduces the proxy attribute in ClientOptions where this PR is relying on.

You should run npm link on common-js and then run npm link configcat-common in this PR. Then it should work.

configcat commented 4 years ago

I have tested, merged and released a new version. Thank you very much for the contribution and the help!

ziofat commented 4 years ago

Great! I was worried about the SSR thing.