configcat / ruby-sdk

ConfigCat SDK for Ruby. ConfigCat is a hosted feature flag service: https://configcat.com. Manage feature toggles across frontend, backend, mobile, desktop apps. Alternative to LaunchDarkly. Management app + feature flag SDKs.
https://configcat.com/docs/sdk-reference/ruby
MIT License
12 stars 3 forks source link

Consistent log messages #19

Closed adams85 closed 1 year ago

adams85 commented 1 year ago

Describe the purpose of your pull request

Revises log messages to make them consistent with other SDKs and also adds event ids for easier log event identification.

Note: I haven't implemented structured logging but AFAICS the logging abstraction makes it possible without much pain. If we want to enable structured logging, I have some ideas how to do it.

Requirement checklist (only if applicable)

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (239fd3b) 99.50% compared to head (a4a8161) 99.51%.

:exclamation: Current head a4a8161 differs from pull request most recent head e5d63d0. Consider uploading reports for the commit e5d63d0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #19 +/- ## ========================================== + Coverage 99.50% 99.51% +0.01% ========================================== Files 13 13 Lines 1212 1244 +32 ========================================== + Hits 1206 1238 +32 Misses 6 6 ``` | [Impacted Files](https://codecov.io/gh/configcat/ruby-sdk/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat) | Coverage Δ | | |---|---|---| | [spec/configcat/lazyloadingcachepolicy\_spec.rb](https://codecov.io/gh/configcat/ruby-sdk/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat#diff-c3BlYy9jb25maWdjYXQvbGF6eWxvYWRpbmdjYWNoZXBvbGljeV9zcGVjLnJi) | `100.00% <100.00%> (ø)` | | | [spec/configcat/manualpollingcachepolicy\_spec.rb](https://codecov.io/gh/configcat/ruby-sdk/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat#diff-c3BlYy9jb25maWdjYXQvbWFudWFscG9sbGluZ2NhY2hlcG9saWN5X3NwZWMucmI=) | `100.00% <100.00%> (ø)` | | | [spec/datagovernance\_spec.rb](https://codecov.io/gh/configcat/ruby-sdk/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat#diff-c3BlYy9kYXRhZ292ZXJuYW5jZV9zcGVjLnJi) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=configcat)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication