Fix wrong return value of get_value_details() in case config JSON is not present

configcat / ruby-sdk

ConfigCat SDK for Ruby. ConfigCat is a hosted feature flag service: https://configcat.com. Manage feature toggles across frontend, backend, mobile, desktop apps. Alternative to LaunchDarkly. Management app + feature flag SDKs.

https://configcat.com/docs/sdk-reference/ruby

MIT License

12 stars 3 forks source link

Fix wrong return value of get_value_details() in case config JSON is not present #31

Closed kp-cat closed 9 months ago

kp-cat commented 9 months ago

Describe the purpose of your pull request

get_value_details() returns an EvaluationDetails object in case config JSON is not present

Requirement checklist (only if applicable)

[ ] I have covered the applied changes with automated tests.
[ ] I have executed the full automated test set against my changes.
[ ] I have validated my changes against all supported platform versions.
[x] I have read and accepted the contribution agreement.

sonarcloud[bot] commented 9 months ago

Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint