confio / poe-contracts

Tgrade PoE smart contracts
Apache License 2.0
25 stars 11 forks source link

Add half-life event member updates #204

Closed maurolacy closed 1 year ago

maurolacy commented 1 year ago

Closes #203.

Opted for straightforward changes for the fix, instead of a full refactoring. Member.points is unsigned, and adding more complexity to update_members doesn't look like a good idea. In fact, perhaps it would be better to break down update_members into add_members and remove_members (as suggested in the past), and then add a new halve_members in parallel.

TODO:

maurolacy commented 1 year ago

This bug shows the limits of unit testing, by the way. Everything is properly unit tested, and still this is wrong, and fails in an integrated environment.