confio / tfi

Contracts for Regulated DeFi on the Tgrade blockchain
Apache License 2.0
9 stars 0 forks source link

Multitest veryfing full tfi-factory workflow #44

Closed hashedone closed 3 years ago

hashedone commented 3 years ago

Closes #9

I didn't created proposed test with two separated groups, as I don't see reason for it - it is tested that if one is not a member of group related with token, it cannot trade, I don't see reason why to check if adding same member to completely unrelated group might change anything. Also this test would be more complicated than others. If there is real need for such test then I can spend more time to provide it.

One single bug is corrected with this PR as I found it with one of tests - arguments was swapped in one place, which caused creating invalid response for Pair query.

Also I am not sure about one thing - tfi-factory requires actual cw20-base contract to manage liquidity tokens. It is caused by fact, that it doesn't know about whitelists, so it is unable to instantiate liquidity token to be dso-token. I am not sure if it is by design, or just oversight.