search

confio / tfi

Contracts for Regulated DeFi on the Tgrade blockchain
Apache License 2.0
9 stars 0 forks source link

Redeem implementation for dso-token #46

Closed hashedone closed 3 years ago

hashedone commented 3 years ago

Still draft, as test are to be written (working on this right now, just wanted to expose what is done already).

hashedone commented 3 years ago

@maurolacy you are not annoying, I know I am communicative in English, but not fluent. As I write more docs here I would probably look for some spell checking plugin for vim (but it would need to be one which checks only comments to be reasonable).

maurolacy commented 3 years ago

As I write more docs here I would probably look for some spell checking plugin for vim (but it would need to be one which checks only comments to be reasonable).

Intellij Idea does a good job with spelling IMO. Spelling mistakes are highlighted, you can press F2 to see next error / suggestion. And you can add misspelled words / variable names to an allowed list.

hashedone commented 3 years ago

@ethanfrey @maurolacy final review-ready version.

Added only single test. I was playing around how to improve it, but basically too much to do for the scope of this. I want to improve query mocking, so it is easy to use it with minimal boilerplate, by having configurable mock (I have an idea how to approach this in future using mockall). Also there should be some way to easy verify events which occurred.