confio / tgrade-app

Tgrade - building a secure, regulatory friendly, decentralised finance platform.
https://dapp.tgrade.finance
Apache License 2.0
4 stars 4 forks source link

Cookie banner appears after reload #419

Closed abefernan closed 2 years ago

abefernan commented 2 years ago

Steps

current

expected

Related issue

420

abefernan commented 2 years ago

I don't think we should do this until we have a button or something that lets us show the banner again. This is because apparently "GDPR requires that the consent provided for the collection, processing, storing of data is reversible".

kmw101 commented 2 years ago

Could you put a hyperlink/button below the connect wallet/address which says cookies and when the user clicks the banner appears?

abefernan commented 2 years ago

Could you put a hyperlink/button below the connect wallet/address which says cookies and when the user clicks the banner appears?

Since the Connect wallet button is pushed to the bottom it would be much feasible to put it below Address generator.

abefernan commented 2 years ago

I have added a "Cookies" button that shows the banner in #469, but I believe the "disable appear after reload" needs to be done from the CookieYes dashboard. I don't know if anyone has access to the dashboard besides @ks-victor.

Ebazhanov commented 2 years ago

I have added a "Cookies" button that shows the banner in #469, but I believe the "disable appear after reload" needs to be done from the CookieYes dashboard. I don't know if anyone has access to the dashboard besides @ks-victor.

my idea maybe we can have some confio.slab page with description of how to get into it (for the future reference)

ks-victor commented 2 years ago

I cannot reproduce this error on try.tgrade.finance - so it actually works :D

We only have a paid account for try. and just "misuse" the cookie banner on the staging environment. Hence it only sets cookie on try. and not on staging and hence you experience this issue on staging. (and FYI: there is no "disable appear after reload" option).

The banner can be located on different places on the screen so that it doesn't cover key functionality.

abefernan commented 2 years ago

I just deployed the latest version of the code to dapp.tgrade.finance in order to check the functionality of the cookie banner, the cookies button, and the correct storage of Google Analytics' cookies.

I have tested that:

Ebazhanov commented 2 years ago

Safari cookie state does not change to "NO" after clicking on "Reject All" button

https://user-images.githubusercontent.com/13170022/158561389-08f1c58c-b462-4e4b-a468-eb881345e012.mp4

@ks-victor @daniellarita if there is no priority to check in Safari this ticket is verified

BirgitPohl commented 2 years ago

For data privacy reasons it should have a wider range than Tgrade itself.

ks-victor commented 2 years ago

@Ebazhanov it seems like that a refresh click is required before it works.

Ebazhanov commented 2 years ago

@ks-victor true, maybe it is specific behavior of Safari and cookies service which we are using, I reported it because in case if user will not refresh, the state will not be changed. do not know how it is critical, it is just my observation

ks-victor commented 2 years ago

@Ebazhanov thx. Appreciated. Let’s leave it at that for the moment. We hardly have any Safari traffic anyway. If @Danielle is fine with it, I would suggest closing this one.

@BirgitPohl in which way?

abefernan commented 2 years ago

It was closed when Kain set the new domain