search

confio / ts-relayer

IBC Relayer in TypeScript
MIT License
109 stars 63 forks source link

Ensure we support sdk v0.43 as well #192

Closed ethanfrey closed 2 years ago

ethanfrey commented 3 years ago

This seems to have some breaking changes (in events at least... maybe some in protobuf msg?) from 0.42, so the relayer must be smart enough to handle it.

See https://github.com/informalsystems/ibc-rs/issues/918 and https://github.com/informalsystems/ibc-rs/issues/1057

ethanfrey commented 3 years ago

We should also favor the packet_data_hex attribute (if present) over packet_data.

This is only present in ibc-go: https://github.com/cosmos/ibc-go/blob/main/modules/core/04-channel/keeper/packet.go#L135

ethanfrey commented 2 years ago

This should work with CosmJS 0.27. We need to test the ibc semantics, maybe add hex_data etc. Definitely need to update CI script

webmaster128 commented 2 years ago

Please note that the simapp 0.44 (maybe 0.43 as well) does not include IBC support anymore because the ibc module was removed from the cosmos-sdk repo. So this might require changes to the test setup.

ethanfrey commented 2 years ago

Oh no. I guess I can test with gaia v6.0 or something... and ensure both 0.42 and 0.44 support? And then ibc 1.2 and ibc 2.0? ugh

ethanfrey commented 2 years ago

Closed by #214 as gaiad v6 is using Cosmos SDK 0.44 and ibcv2