Fix header validation error - Githubissues

confio / ts-relayer

IBC Relayer in TypeScript

MIT License

109 stars 63 forks source link

Fix header validation error #285

Closed NoahSaso closed 8 months ago

NoahSaso commented 8 months ago

I think I solved the infamous header failed basic validation error!

Query failed with (6): rpc error: code = Unknown desc = header failed basic validation: commit signs block 333F5ECBE51CA88088C64523E7CF156A67695D949ABC23E02270FA57EF2D4269, header is block 444DB206D17B81B86392FCB24AF2162B956EBC5D7FBE367ACE3213545AAD926B [cosmos/ibc-go/v6@v6.2.0/modules/light-clients/07-tendermint/types/header.go:62] With gas wanted: '0' and gas used: '46662' : unknown request

It appears a field of the header was not being copied over correctly. Presumably it would succeed when rpcHeader.version.app was 0, and fail the rest of the time.

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: 7e1549989e86a258651c35f0ce2261f468d61801

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------------- | ----- | | @confio/relayer | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

NoahSaso commented 8 months ago

Looks correct to me. If this helps, great!

sweet! let me know when we can merge and publish a new version :)

seems like the CI isn't running

webmaster128 commented 8 months ago

Can you try version 0.12.0?

NoahSaso commented 8 months ago

Can you try version 0.12.0?

yep, one minute

NoahSaso commented 8 months ago

Can you try version 0.12.0?

yep, one minute

first two tests succeeded!

it's hard to verify because it was never deterministic, but the fact that two succeeded in a row was very rare before, so it seems to be working 🥳