confirm / mopidy-pummeluff

Pummeluff is a Mopidy extension which allows you to control Mopidy via RFID cards
MIT License
15 stars 15 forks source link

[Feature Request] Next/Previous Track Action #13

Closed tobru closed 4 years ago

tobru commented 4 years ago

When working with playlists it would also be great to have a tag to skip forward to the next track or back to the previous one in the playlist. This "Class" is currently not available and it would be fantastic to have it available.

domibarton commented 4 years ago

Should be doable… let me peek at the official Mopidy API.

domibarton commented 4 years ago

YAY… Should be really simple, as it's the same playback controller class as the play / resume one:

https://docs.mopidy.com/en/latest/api/core/#mopidy.core.PlaybackController.next

tobru commented 4 years ago

I'll give it a try with a PR in the next days :+1:

domibarton commented 4 years ago

No worries, I already have it :)

domibarton commented 4 years ago

I'll probably refactor the code a bit to keep compliant with DRY

domibarton commented 4 years ago

I created a new PR for my new add-next-previous-actions branch. However, I couldn't test the changes yet, because I currently don't have the box at home. I'll give it a try in the next days.

What I can say so far:

Again: I only changed the code on the fly without testing. I'd be surprised if that change already works ^^

domibarton commented 4 years ago

@tobru I created a new release.

You can use the tag v2.2.0, the master branch or the new PyPi package.

Can you test if everything works as expected and let me know? :)

tobru commented 4 years ago

@domibarton I can confirm that it just works :tm: :tada: I'm even impressed that you could read my mind about the new unregister tag possibility which was a thing I was thinking about.

Thank you very much, I owe you a :beer: once it's possible again!

domibarton commented 4 years ago

lolz :D after the corona thingy, we'll have some 🍻 ;)

Yeah the "unregister" feature was in my mind for some time. But I'm a lazy person, so it took some time. Glad it worked :)