Open source licence question...

confirmedcode / Lockdown-iOS

GNU General Public License v3.0

888 stars 86 forks source link

Open source licence question... #19

Closed mikegchambers closed 5 years ago

mikegchambers commented 5 years ago

This code seems to include GCDProxyServer which seems to come from here: https://github.com/zhuhaow/NEKit

This code appears to have a license that would seem to state that there should be acknowledgment for that developer within the app.

@zhuhaow

zhuhaow commented 5 years ago

Thanks @mikegchambers. It seems like they already include NEKit license in the credit file at the root. Not sure about the app since I don't have it installed.

It may be necessary to include that in the app from the legal perspective though I'm not a big fan of textualism. So it would be a better-to-have for me.

What I'm really interested in is why it ships a precompiled NEKit framework in the source. Is there anything that changed but not intended to be open-sourced?

hijohnnylin commented 5 years ago

Hi @zhuhaow and thanks for all your wonderful work on NEKit.

Re: License: we'll add the NEKit license in the app somewhere in the next version (not 0.1.6 which is an emergency regression bug fix)
Re: Precompiled NEKit.framework - I forgot to remove this - the precompiled one is not actually used by the xCode project/workspace, it uses the one in the Carthage build folder. I will remove this also in the next build. Nothing has been changed.

zhuhaow commented 5 years ago

Thank you @hijohnnylin. That would be perfect.

I'm really glad NEKit helped

hijohnnylin commented 5 years ago

Both issues are now resolved in 18c7729b1b9adb0116b4cf6b36c47bf7ac9f1f04

License: All acknowledgements now available via Settings -> Lockdown -> Acknowledgements-Lockdown
Precompiled NEKit.framework - Removed.