search

confirmedcode / Lockdown-iOS

GNU General Public License v3.0
888 stars 86 forks source link

No longer seems to be open source. App store code two months newer. #38

Closed Workings closed 4 years ago

Workings commented 4 years ago

When will the last two months of code be committed to the repo? Or is this code private?

BCtopics commented 4 years ago

+1

This seems to be the same issue as #14

Apparently they don't care to actually have an open-source project. If they want to claim this is Open Source then they should be working off of this repository. Not a private one somewhere else, and occasionally updating this one to match. It seems suspicious to me.

@hijohnnylin

stalcottsmith commented 4 years ago

This app looks interesting but the developers clearly do not understand open source development based on the comment thread in #14 . I assume they are young and/or from outside open source culture. It is customary to use a public repo for open source dev so that we can see your most recent commits. I see 3-4 months ago as latest changes and no branches here. Clearly they are developing on a private repo or not at all.

stalcottsmith commented 4 years ago

What's further is that their commits are huge! There are only 6 commits on this repo. That is horrible for anyone trying to do code review. Change sets should be as small as possible and merges frequent. This is how teams develop and open source works. This feels like the project of a solo dev who never worked in a team or contributed to someone else's open source project.

I am trying to build this on my Xcode and get errors for missing components but there are no build instructions provided. I want this but I don't trust.

hijohnnylin commented 4 years ago

Hey folks:

1) I just pushed the latest code. Apologies for delays -- we've been busy trying to get this on the other platforms and didn't have time to self-audit the code before pushing to Github. Tried using Catalyst to build on Mac but it turns out that Catalyst is very buggy and not quite ready for prime time yet. (rdar://problem/56212319). We'll be releasing Lockdown Mac in the next few days (with source!), hopefully through MAS.

2) @stalcottsmith - can you let me know the details of the errors? The build instructions are in the README: "To build the app from source, please make sure to run a 'pod install' & 'carthage update --no-use-binaries --platform ios' and open the *.xcworkspace file to build. To sign the app, you will need an Apple Developer account."