confirmedcode / Lockdown-iOS

GNU General Public License v3.0
888 stars 86 forks source link

Fixed vertical alignment of power button icon. #44

Closed lmjabreu closed 3 years ago

lmjabreu commented 4 years ago

Long story short: the power icon needed to be vertically adjusted. I changed the asset directly to avoid changing constraints and reduce the change-set. By changing the asset it's also easier to avoid this mistake in the future as you can just re-use the asset and do the natural thing which is to vertically centre the asset. No need to remember to offset it vertically and by how much.

Reference article about when to use visual instead of mathematical alignment: https://uxdesign.cc/7-principles-of-icon-design-e7187539e4a2#695d

Awesome piece of software, thank you so much, but this had been bothering me for months 😅 Sadly I don't have time to improve other bits.

hijohnnylin commented 4 years ago

Heya, thanks for this and I did see the interesting/amusing discussion about this on Twitter. Will test this and see if we can pull it in the next v.

lmjabreu commented 4 years ago

Bump 🙂

hijohnnylin commented 3 years ago

Switching to a vector icon from SF Symbols in 6ee5e1d07758af0b0454e9177469c30df7d90c6b, which looks a lot more "centered":

image