confluentinc / bottledwater-pg

Change data capture from PostgreSQL into Kafka
http://blog.confluent.io/2015/04/23/bottled-water-real-time-integration-of-postgresql-and-kafka/
Apache License 2.0
3 stars 149 forks source link

Check for memory leaks during CI build #108

Closed samstokes closed 8 years ago

samstokes commented 8 years ago

This PR:

  1. Adds support to the BW Docker image for running the BW client under Valgrind if the environment variable VALGRIND_ENABLED is set;
  2. Runs the core functionality tests under Valgrind as part of the CI build on Travis.
  3. Fixes a couple of harmless memory leaks, so that Valgrind reports no errors at time of PR submission.

This means any subsequent commits and PRs to the client daemon will get automatically checked for memory leaks.

I haven't yet looked into Valgrinding the Postgres extension; I expect that to be trickier, because of the custom palloc allocator used there, and because it runs inside a forked child of Postgres rather than a standalone executable.