search

confluentinc / bottledwater-pg

Change data capture from PostgreSQL into Kafka
http://blog.confluent.io/2015/04/23/bottled-water-real-time-integration-of-postgresql-and-kafka/
Apache License 2.0
2 stars 0 forks source link

Support arbitrary-precision numbers #4 #114

Closed buzila closed 7 years ago

buzila commented 7 years ago

We could use logic for "double" type ti avoid "0.0" values. It is not full support for Decimal type, but it is useful for most cases.

ghost commented 7 years ago

It looks like @buzila hasn't signed our Contributor License Agreement, yet.

Appreciation of efforts,

clabot

buzila commented 7 years ago

[clabot:check]

ghost commented 7 years ago

It looks like @buzila hasn't signed our Contributor License Agreement, yet.

Appreciation of efforts,

clabot

samstokes commented 7 years ago

Hi @buzila, thanks very much for this contribution! I agree that using "double" is better than just using zero :) We should still keep issue #4 open to document the potential loss of precision though.

I'd love to merge this, once we get the Travis CI build passing. There's currently a test for the numeric type that's marked as expected to fail, so we should remove that expectation and run the test normally. (It's just testing with the value 42, so the test should pass with your fix.) It should be sufficient to remove the type from the KNOWN_BUGS hash in generate_type_specs.rb.

I'm not sure what's going on with @ConfluentCLABot - were you able to complete the form and sign the CLA? I wonder if there's a bug with the bot, if it's still complaining after that.

buzila commented 7 years ago

It should be sufficient to remove the type from the KNOWN_BUGS hash in generate_type_specs.rb.

Thank you. I couldn't find this place.

buzila commented 7 years ago

I'm not sure what's going on with @ConfluentCLABot - were you able to complete the form and sign the CLA? I wonder if there's a bug with the bot, if it's still complaining after that.

I feel stupid, but I don't understand where I could find the form. There is no links or buttons to it. I found this https://cla.github.com/agreement, but there is no accept button too. And I can't find anything in google about it.

buzila commented 7 years ago

As I can see in CLABot demo https://clabot.github.io/ the link must be in ConfluentCLABot'd reply.

2016-08-31 0 46 25
samstokes commented 7 years ago

Gah, sorry @buzila, it's me that's being stupid! I keep forgetting @ConfluentCLABot stopped including the CLA link in its messages a while ago. (No idea why, since as you pointed out, it's really confusing without the link!)

You can read and sign the CLA online here.

buzila commented 7 years ago

[clabot:check]

ghost commented 7 years ago

@confluentinc It looks like @buzila just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

samstokes commented 7 years ago

Thanks very much @buzila !