search

confluentinc / camus

Mirror of Linkedin's Camus
Apache License 2.0
0 stars 62 forks source link

Execute debug specific code only when debug logging is enabled #31

Closed galak-fyyar closed 8 years ago

galak-fyyar commented 8 years ago

Current 1.0.1 release has a major performance defect caused by excessive debug logging in [camus-kafka-coders/src/main/java/io/confluent/camus/etl/kafka/coders/AvroMessageDecoder.java#L113]:

logger.debug("Schema = " + schema.toString());

Schema is serialized each time new message arrives. However, as debug logging is disabled it is never printed to log.

Applied fix showed up to 10x performance improvement.

PR is submitted to 1.x-0.9.0.0 branch as it seem to be the most active for 1.x version.

ConfluentJenkins commented 8 years ago

Can one of the admins verify this patch?

ghost commented 8 years ago

It looks like @anatoliy-sokolenko hasn't signed our Contributor License Agreement, yet.

Appreciation of efforts,

clabot

ewencp commented 8 years ago

This was really an upstream problem, although the upstream project has been deprecated. Camus is also deprecated from CP 3.0.0 on and we won't be making further changes.