confluentinc / cli

CLI for Confluent Cloud and Confluent Platform
https://docs.confluent.io/confluent-cli/current/overview.html
Other
56 stars 10 forks source link

chore: consistent usage of regions across tests #2852

Closed YannickPferr closed 4 months ago

YannickPferr commented 4 months ago

Release Notes

Checklist

What

Last PR broke tests on master. The failure came from the fact that we had an inconsistent usage of regions across tests. Gateway test handlers were assuming things to be in eu-west-1 but then the compute pool handlers returned us-west-1/us-west-2 regions. This PR aligns the regions between those two test backends

References

Test & Review

It looks like the integration tests do not run on PRs anymore, so this time I ran them locally to confirm they all pass

EDIT: actually, the integration tests do run on PRs. The failure happened because of a semantic merge conflict with this PR. The new tests were merged before my PR was merged, and my branch wasn't up to date.