search

confluentinc / common-docker

Confluent Commons with support for building and testing Docker images.
Apache License 2.0
4 stars 69 forks source link

DP-13727 Add CodeArtifact package paths to service.yml #389

Closed huizheng278 closed 7 months ago

huizheng278 commented 8 months ago

One of the Capsaicin requirements requires that all artifacts uploaded to CodeArtifacts come from specific Semaphore jobs. This PR adds package_paths to service.yml so that each GitHub repo can declare the path of the CodeArtifact packages that it writes to. For newer GitHub repos, the package_paths needs to be added to the service.yml file manually before it can write to CodeArtifact in the Semaphore pipeline. For more information about this, see https://confluent.slack.com/archives/C038ZJ00P/p1708464192287999

cla-assistant[bot] commented 8 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: hui-zheng278
:x: cchristous
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] commented 8 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

rahejaprince commented 8 months ago

This PR needs to be merged into 6.2.x and then pint merged to master

huizheng278 commented 7 months ago

This PR needs to be merged into 6.2.x and then pint merged to master

@rahejaprince Since you are the owner of the repo, I'll leave it to you to decide how to merge.

rahejaprince commented 7 months ago

This PR needs to be merged into 6.2.x and then pint merged to master

@rahejaprince Since you are the owner of the repo, I'll leave it to you to decide how to merge.

Please change the base of this PR to 6.2.x branch and we can then pint merge it once this PR is merged. Please resolve conflicts also.

cchristous commented 7 months ago

Please change the base of this PR to 6.2.x branch and we can then pint merge it once this PR is merged. Please resolve conflicts also.

This PR and the like was opened as a best effort courtesy for all repos. Please get this change into the default branch of this repo in whatever way you deem best. If this is not done so by March 25, the repo will be unable to push artifacts to CodeArtifact