search

confluentinc / common-docker

Confluent Commons with support for building and testing Docker images.
Apache License 2.0
4 stars 69 forks source link

minor: add use_packages and cp_images #405

Closed jkao97 closed 8 months ago

jkao97 commented 8 months ago

Change Description

Would like to enable these parameters to get the changes in developement. Using this project as a testing ground.

Testing

The templates have unittest. Integrating with this project is for further testing.

cla-assistant[bot] commented 8 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] commented 8 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

jkao97 commented 8 months ago

thanks @jkao97, don't we need to add any tasks here in service.yml?

I want to allow service bot to generate the tasks files themselves so I don't miss anything. I will be making another PR for that change along with the task file generation.