search

confluentinc / common-docker

Confluent Commons with support for building and testing Docker images.
Apache License 2.0
4 stars 69 forks source link

feat: testing new cp_dockerfile templates #406

Closed jkao97 closed 7 months ago

jkao97 commented 8 months ago

Change Description

Testing tasks. Removed pushes that may conflict with the current build. Build only pushes packaging tag. Promotion takes packaging tag and retags (push has been removed for promotions)

Testing

cla-assistant[bot] commented 8 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] commented 8 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

jkao97 commented 7 months ago

thanks James, so, we have removed docker pushes from both the tasks - build and promote? lgtm.. let's test with this

yeah build typically has a deploy stage that pushes to internal repositories. promote then takes the image from internal, retags and pushes to dockerhub. I've removed any pushes in both except for the image that is used in promote and dev-* images.