confluentinc / common

Common utilities library containing metrics, config and utils
Apache License 2.0
4 stars 243 forks source link

disable retirejs #559

Closed bennettzhu1 closed 10 months ago

bennettzhu1 commented 10 months ago

What

RetireJS (a plugin dependency consumed by dependency-check that we use) is causing issues with builds. Examples:

[ERROR]     InitializationException: Failed to initialize the RetireJS repo: `/tmp/dctemp772c4170-e777-4d8b-bb31-6af8dfbccdf2/jsrepository.json` appears to be malformed. Please delete the file or run the dependency-check purge command and re-try running dependency-check.02:49
[ERROR]         caused by JSONException: No value for info

This is blocking builds and a known issue, rather than waiting for a fix we can disable it for the time being by adding the ```

false``` parameter ### Testing We copied the dependency-check profile to this [repo's](https://github.com/confluentinc/metadata-service/pull/1959/files) pom.xml, built it as is, and the build failed with the error above. Then added this parameter ```false``` and the build passed that stage
cla-assistant[bot] commented 10 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] commented 10 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

eoftedal commented 10 months ago

retire.js repo has been fixed