search

confluentinc / common

Common utilities library containing metrics, config and utils
Apache License 2.0
4 stars 243 forks source link

added a new docker-arm profile to build docker containers in arm64 #563

Closed sriki-cflt closed 8 months ago

sriki-cflt commented 10 months ago

This change adds support to build docker images on arm64 machines/laptops.

The following are the changes I have made

  1. Added a new profile docker-arm that uses the io.fabric8:docker-maven-plugin
  2. This plugin supports docker image building in arm64 laptops.

Ensuring Backward compatibility and minimum interference with existing plugin:

  1. Completely new build profile isolates the build process.
  2. added additional property: docker.imagePullPolicy default in the common default this will not be used by existing plugin hence no interference.
  3. the new plugin requires defaults for some of existing properties; added these as defaults in plugin scope so that they do not impact the existing plugin.
cla-assistant[bot] commented 10 months ago

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] commented 10 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

janjwerner-confluent commented 9 months ago

@sriki-cflt This scope of work will require review from DevProd as this affects the build pipeline more than security. I have requested their review. In the meantime - the downstream validation fails building images - that will need a resolution.

sriki-cflt commented 9 months ago

@janjwerner-confluent Thank you for point out the build failures. I have rerun the build it has passed. https://github.com/confluentinc/common/pull/563/checks?check_run_id=18810208067 The failures were 403 for downloading while downloading artifacts - hence re run solved it.

janjwerner-confluent commented 9 months ago

great, looks good to me, can you please wait for someone from @confluentinc/devprod to sign of it as well.

rramakrishnan7 commented 9 months ago

@wadhwa1 can you approve changes from cp-release side. @xli1996 comment on slack.

The changes overall lgtm, but devprod is not codeowner to these two repos anymore. Seems security and cp-release team’s approval will grant the merge.