search

confluentinc / common

Common utilities library containing metrics, config and utils
Apache License 2.0
4 stars 243 forks source link

Upgrade EasyMock version to be compatible with Jdk 17+ #575

Open trnguyencflt opened 10 months ago

trnguyencflt commented 10 months ago

The version of easymock in 7.3.x branch is 5.2.0 while all 7.3.x-post branches are 4.3.

EasyMock version 4.3 isn't compatible with Jdk 17 (used in Semaphore) so upgrading it. As far as compatibility issue concern, as EasyMock 5.2.0 is used in branch 7.3.x already, it should not be a problem.

cla-assistant[bot] commented 10 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cla-assistant[bot] commented 10 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

trnguyencflt commented 10 months ago

lgtm, started a rebuild as the pr merge test failed downloading kafka artifacts. let's see the outcome of the downstream validation.

@janjwerner-confluent thanks, the build on Jenkins still fail with this error for which I don't really know how to fix 😢 

13:03:25  [ERROR] Failed to execute goal io.confluent:resolver-maven-plugin:0.5.0:resolve-kafka-range (default-cli) on project common-parent: MojoExecutionException: Could not find any ce-kafka artifacts. -> [Help 1]

Is that still ok to merge?