confluentinc / common

Common utilities library containing metrics, config and utils
Apache License 2.0
1 stars 241 forks source link

DGS-10520: Update netty to 4.1.108-Final #597

Closed sriman-confluent closed 3 months ago

sriman-confluent commented 3 months ago

Updating dependency based on this ticket by Jira bot https://confluentinc.atlassian.net/browse/DGS-10520. Will be pint merged to master

cla-assistant[bot] commented 3 months ago

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

akhileshm1 commented 3 months ago

is semaphore not supposed to work here?

sriman-confluent commented 3 months ago

is semaphore not supposed to work here?

Semaphore isn't supported on 6.0.x branches as per https://confluent.slack.com/archives/C09EP1SS3/p1714153242929679?thread_ts=1714152218.285859&cid=C09EP1SS3

sriman-confluent commented 3 months ago

Jenkins build passes but starting downstream repo expectedly fails due to secret-registry not having Jenkins on 6.0.x anymore.

13:35:58  [INFO] ------------------------------------------------------------------------
13:35:58  [INFO] Reactor Summary for newwave 6.0.16-SNAPSHOT:
13:35:58  [INFO] 
13:35:58  [INFO] newwave ............................................ SUCCESS [  4.671 s]
13:35:58  [INFO] kafka-mqtt ......................................... SUCCESS [ 13.360 s]
13:35:58  [INFO] ------------------------------------------------------------------------
13:35:58  [INFO] BUILD SUCCESS
13:35:58  [INFO] ------------------------------------------------------------------------
13:35:58  [INFO] Total time:  18.394 s
13:35:58  [INFO] Finished at: 2024-04-26T18:35:58Z
13:35:58  [INFO] ------------------------------------------------------------------------
13:35:58  [INFO] [jenkins-event-spy] Generated /home/jenkins/workspace/ic_Repo_PR_builder_common_PR-597@tmp/withMavendd54836e/maven-spy-20240426-183540-28610417227055290033868.log
13:35:58  + cd ..
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // wrap
[Pipeline] }
[Pipeline] // withCredentials
[Pipeline] sh
13:35:59  + rm downstream.json
[Pipeline] echo
13:35:59  fail on secret-registry-6.0.x
[Pipeline] echo
13:35:59  fail on ksql-6.0.x
janjwerner-confluent commented 3 months ago

@sriman-confluent This should be merged into 6.2.x and pint merged up. Also, https://github.com/confluentinc/common/pull/595 broke down the downstream builds so we should hold on with the updates until we revert that one.