[WIP] Include kafkacat, produce, consume in Confluent CLI with default brok…

confluentinc / confluent-cli

Confluent Platform CLI

Other

60 stars 38 forks source link

[WIP] Include kafkacat, produce, consume in Confluent CLI with default brok… #85

Closed ybyzek closed 6 years ago

ybyzek commented 6 years ago

…er localhost:9092

Value prop: https://confluentinc.atlassian.net/wiki/spaces/PM/pages/540442869/1-pager+Package+Kafkacat+and+Confluent+Cloud+CLI

Description:

Assumes users install kafkacat independently (kafkacat not bundled with CP at this time)
Optimize calls to kafkacat with a confluent CLI wrapper, so it can be invoked as follows:

Example:

~: confluent produce -t test1
a
b
c
^C^C^C^C^C^C^C^C^C^C^C
~: confluent consume -t test1
a
b
c
% Reached end of topic test1 [0] at offset 3
^C%

ybyzek commented 6 years ago

My overall concern is whether it's worth depending on kafkacat to implement confluent produce and confluent consume or we could just use existing scripts under bin/? Does the imported functionality and the difference from available producer/consumer scripts worth the extra step to install kafkacat?

@kkonstantine : until Converged CLI subsumes all of the current CLIs, my position is that the answer is yes. The value prop of kafkacat is described here: https://confluentinc.atlassian.net/wiki/spaces/PM/pages/540442869/1-pager+Package+Kafkacat+and+Confluent+Cloud+CLI

ybyzek commented 6 years ago

Cancelling this PR, in favor of https://github.com/confluentinc/confluent-cli/pull/91