Closed ybyzek closed 6 years ago
@jrjain , @kkonstantine
I believe the summary of outstanding issues to resolve are of a philosophical nature:
Do we want users to be able to use confluent produce/consume
for non-local Kafka clusters? I strongly believe the answer is yes, and thus the code is written to accept overrides for broker-list
and bootstrap-servers
. I believe @kkonstantine feels the other way.
Do we want users to be able to explore and use other options provided by the bin commands, which may or may not conform to future Converged CLI? I believe the answer is yes to improve greatest utility, and thus the code is written to point users in that direction. I believe @kkonstantine feels the other way. Possible compromise: remove mention of it from the usage description, but still allow those args to be passed in.
The code makes sense, but I'm confused why one flag is --value-format avro
and the other is --property value.schema
instead of having them match, e.g. value-schema=
?
Also I'm confused why --value-format
takes a space, and `value-schema
takes an =
to separate from argument? Might be overkill to support both options, but consistency is good.
https://stackoverflow.com/questions/7069682/how-to-get-arguments-with-flags-in-bash-script shows a nice idiom, but is probably overkill
@cyrusv , it's because this is hybrid of two CLIs: --value-format avro
is in anticipation of upcoming Converged CLI and --property value.schema
is what's currently available in the bin command
Would it make sense to abstract the difference and just expose --avro | --avro-value | --avro-key and then use the proper argument based on underlying tool?
Would it make sense to abstract the difference and just expose --avro | --avro-value | --avro-key and then use the proper argument based on underlying tool?
@edenhill there is an argument for that, but --value-format avro
was by request of @jrjain to use the Converged CLI syntax.
Not Avro:
Avro: