search

confluentinc / confluent-docker-utils

Common Python utils for testing Confluent's Docker images
Apache License 2.0
3 stars 3 forks source link

Requests version requirements? #1

Closed simplesteph closed 3 years ago

simplesteph commented 6 years ago

https://github.com/confluentinc/confluent-docker-utils/blob/master/requirements.txt#L4

This line has: requests!=2.11.0,<2.12,>=2.6.1

We usually have request 2.18 running and this requirement breaks our scripts out of the box. Things used to work in 3.3.1 with this.

Is there any reason to enforce stricter requirements on requests package? And not use the latest 2.18.4?

cf https://github.com/confluentinc/cp-docker-images/issues/386

ewencp commented 6 years ago

@aayars Any ideas here? Looks like you were previously updating to 2.13 but ended up reverting it.

aayars commented 6 years ago

It may have been due to the docker-compose API, IIRC. Could try bumping to latest to see what breaks!

andrewegel commented 3 years ago

We have since bumped the requests version and dropped python2.7 support.