search

confluentinc / confluent-docker-utils

Common Python utils for testing Confluent's Docker images
Apache License 2.0
3 stars 5 forks source link

ST-3962: Update jinja2 version to latest #23

Closed niteshmor closed 4 years ago

niteshmor commented 4 years ago

@confluentinc/tools what would be a good way to verify that this doesn't affect the rendered output? Any example usage of dub.py template that I can look at?

andrewegel commented 4 years ago

I left a comment in https://github.com/confluentinc/common-docker/pull/86 on how you can test this PR's change in the actual images build process. I would like to see that testing done before I give this change my ship-it.

niteshmor commented 4 years ago

I left a comment in confluentinc/common-docker#86 on how you can test this PR's change in the actual images build process. I would like to see that testing done before I give this change my ship-it.

Sounds good. Testing is good, because there seem to be a few minor behavior changes based on reading the release notes... Not sure if they really affect us.

niteshmor commented 4 years ago

The pull request in common-docker has a green build. https://jenkins.confluent.io/job/confluentinc-pr/job/common-docker/job/PR-86/2/

The usage of jinja2 in dub is quite simple: using environment variables to populate config files. Such basic usage shouldn't really be affected much by the requested version upgrade. Reading the release notes, the risk of any downstream disruption is low in my assessment.