search

confluentinc / confluent-docker-utils

Common Python utils for testing Confluent's Docker images
Apache License 2.0
3 stars 5 forks source link

Update Jenkinsfile Nodelabel #36

Closed jkao97 closed 3 years ago

jkao97 commented 3 years ago

Update Jenkinsfile Nodelabel to use new build image.

jkao97 commented 3 years ago

Question for folks reviewing:

Can we move this to ubuntu-20-python (PR tested with a previous commit: f666a5a) instead since it's using the python closure? The deploy part might fail since this java base image does not have twine. Besides the difference in image, this will also run on the main cluster instead of the one for isolated docker image builds.

If moving to the new nodelabel is not an option we might need to install twine on the java based image or install here: https://github.com/confluentinc/jenkins-common/blob/ff8f12e2130136f08687b3d5438ac6d14e18ea0e/resources/scripts/publish-python-package.sh#L20

andrewegel commented 3 years ago

Can we move this to ubuntu-20-python (PR tested with a previous commit: f666a5a) instead since it's using the python closure? The deploy part might fail since this java base image does not have twine.

Yeah lets do that.