search

confluentinc / confluent-docker-utils

Common Python utils for testing Confluent's Docker images
Apache License 2.0
2 stars 3 forks source link

replace homedir #56

Closed lyao-77 closed 1 year ago

lyao-77 commented 1 year ago

homedir substitution is no longer supported for tox new version as well. refer to: https://tox.wiki/en/latest/config.html#environment-variable-substitutions

It's weird that the last PR build is successful despite it is still using homedir

update: loos like the PR build didn't run the test.

vinnybod commented 1 year ago

We solved this in the other repos by using package_root

https://github.com/confluentinc/common-tools/pull/1082 https://github.com/confluentinc/docs-include/pull/206/files

lyao-77 commented 1 year ago

https://github.com/confluentinc/docs-include/pull/206/files

I used env:home in this PR: https://github.com/confluentinc/workspace-tools/pull/15 By reading this doc: https://tox.wiki/en/latest/config.html#environment-variable-substitutions, looks like this is another way to refer home directory.

I guess package_root is another alternative.

work_dir seems work as well

lyao-77 commented 1 year ago

changed to package_root for consistency.