confluentinc / confluent-kafka-dotnet

Confluent's Apache Kafka .NET client

https://github.com/confluentinc/confluent-kafka-dotnet/wiki

Apache License 2.0

2.78k stars 847 forks source link

`DescribeConsumerGroupsAsync` accoring to XML comment accepts null groups collection but failes #2152

Open plachor opened 6 months ago

plachor commented 6 months ago

Description

DescribeConsumerGroupsAsync accorind to XML comment: https://github.com/confluentinc/confluent-kafka-dotnet/blob/a67bd6c06b7eef4293e6476d9ff6f3e93f0e4cd9/src/Confluent.Kafka/IAdminClient.cs#L458-L460

acepts null. However checks count for this enumerable underneath and fail with ArgumentNullException

Checklist

Please provide the following information:

[ ] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[ ] Confluent.Kafka nuget version.
[v2.3.0 ] Apache Kafka version.
[ ] Client configuration.
[ ] Operating system.
[ ] Provide logs (with "debug" : "..." as necessary in configuration).
[ ] Provide broker log excerpts.
[ ] Critical issue.

immutablesemaphore commented 1 month ago

I would also like to understand what the expected behavior of this method is. I see a check for group count here that will fail the call if less than 1 group is declared. Thanks!

https://github.com/confluentinc/confluent-kafka-dotnet/blob/d5d85ea862581381fb318cdcff29e61a5cc72f8d/src/Confluent.Kafka/Impl/SafeKafkaHandle.cs#L2360