confluentinc / confluent-kafka-javascript

Confluent's Apache Kafka JavaScript client
https://www.npmjs.com/package/@confluentinc/kafka-javascript
MIT License
50 stars 5 forks source link

Mismatches between`types/kafkajs.d.ts` and documentation #38

Closed apeloquin-agilysys closed 4 months ago

apeloquin-agilysys commented 5 months ago

While working on a conversion from KafkaJS, I've encountered the following:

milindl commented 5 months ago

Thanks for filing this issue - I'll fix the discrepancies. About the on methods, we don't plan to implement them yet. For the rest, I'll be updating the types.

milindl commented 4 months ago

I've updated the typing and the migration guide. There were a bunch of other places where there were issues like this, or discrepancies between the javascript, typing, and migration, so I've tried to fix those as well.