search

confluentinc / confluent-kafka-python

Confluent's Kafka Python Client
http://docs.confluent.io/current/clients/confluent-kafka-python
Other
3.73k stars 882 forks source link

[CI] list the LICENSE as a license_file #1672

Open emasab opened 7 months ago

emasab commented 7 months ago

Data files are installed in the wrong directory when packaging this, and it is very uncommon to do so. data files should be files needed for the runtime only.

emasab commented 7 months ago

Thanks @dirkmueller @asottile-sentry ! Chose @dirkmueller one because license_files is available since setuptools 42 (Nov 2019) and it's older than 3 years. Confluent Platinum end of support

emasab commented 7 months ago

See #713 #1336.

asottile-sentry commented 7 months ago

why not just merge one of the other PRs instead of committing someone else's PR as yourself?

emasab commented 7 months ago

@asottile-sentry the author is still @dirkmueller. We cannot merge directly because our CI won't run on external code and that code could change any moment, so for security reasons. We're still acknowledging contributions in CHANGELOG.

asottile-sentry commented 7 months ago

talk about "open source" only in name

emasab commented 7 months ago

We're working on a way to run CI directly on external PRs, still after manual review of its code, so we don't have to do this.