search

confluentinc / control-center-images

Docker images for enterprise control center images
Apache License 2.0
19 stars 12 forks source link

Add description label to Dockerfile #37

Closed amitkgupta closed 3 years ago

amitkgupta commented 3 years ago

Some image scanning tools that check for vulnerabilities and OCI image best practices expect to find a description label on images that is not inherited from base images. The proposed change addresses this requirement.

amitkgupta commented 3 years ago

Hey @jessemillerjom what's the process as it relates to merging PRs for this repo? Should I merge once there's a successful review, or should I wait for one of the owners/maintainers to merge? If I should merge, do you have a preference of Create a merge commit, Squash and merge, or Rebase and merge?

srpanwar-confluent commented 3 years ago

Hey @jessemillerjom what's the process as it relates to merging PRs for this repo? Should I merge once there's a successful review, or should I wait for one of the owners/maintainers to merge? If I should merge, do you have a preference of Create a merge commit, Squash and merge, or Rebase and merge?

@amitkgupta Thanks for the change. I can merge it for you

srpanwar-confluent commented 3 years ago

@amitkgupta forgot to ask. Do we want to back port this change?

amitkgupta commented 3 years ago

Hey @srpanwar-confluent I PR'd this to 6.2.x and master. It would be pretty reasonable to backport it and forwardport(?) it to 7.0.x as well. Is there an easy way to do that?

srpanwar-confluent commented 3 years ago

forward port works better. That is how we do for most projects except ce-kafka. You might want to cherry-pick the change 6.2.x based branch. I tried rebasing it from here but it is bringing some additional changes we don't want.