search

confluentinc / control-center-images

Docker images for enterprise control center images
Apache License 2.0
19 stars 12 forks source link

fix: fix baseurl #40

Closed xli1996 closed 3 years ago

xli1996 commented 3 years ago

what

Fix baseurl since clients is removed after 7.1.0(current master)

xli1996 commented 3 years ago

I think that make sense, but I wonder why we did not add it at the first place. Digging through the history seems the original rhel image did have https://github.com/confluentinc/cp-docker-images/blob/5.3.3-post/debian/base/Dockerfile.rpm while new rhel remove that in https://github.com/confluentinc/common-docker/blob/6ab06faa4865928ba54d9d43fc4d8a12daa59275/base/Dockerfile.rhel8.

I think the reason might be that we just want a pure "base" image at the first place, but make it in base image might also help if other people want to build other images since the dockerfile won't need CONFLUENT_PACKAGES_REPO anymore.