search

confluentinc / control-center-images

Docker images for enterprise control center images
Apache License 2.0
19 stars 12 forks source link

Fix version bump in pom.xml for 7.5.x #87

Closed VanamalaNarasimhaBhargav closed 7 months ago

VanamalaNarasimhaBhargav commented 7 months ago

History

  1. During the early phase of jenkins to semaphore migration, there was a randomly dangling PR from Jenkins service bot confluentinc/control-center-images/pull/67 not sure on the origin of this but we suspect that some developer ran service bot and left changes/PR by service bot unmerged.
  2. when service bot was run as part of Jenkins-Semaphore migration some of the commits were pushed to same PR.
  3. This PR from service bot was raised to master branch.
  4. Without realising that this PR contains old changes we megerd it(by changing the target branch to 7.0.x as Jenkins Semaphore migration changes should be back ported to all the branches) but later realised the issue and reverted it at confluentinc/control-center-images/pull/75
  5. Since the base branch was changed to 7.0.x from master, versions were updated in all branches to 7.8. Ideally each branch should point it to its own version.

Goal of this PR is to fix this versioning issue.

How to verify changes? Similar versions can be found in ksql-images/7.5.x/pom.xml

Next Steps

  1. Merge this PR
  2. pint merge with strategy our.
  3. Do the same thing for rest of the branches.
sonarqube-confluent[bot] commented 7 months ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: control-center-images

View in SonarQube

sonarqube-confluent[bot] commented 7 months ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: control-center-images

View in SonarQube

sonarqube-confluent[bot] commented 7 months ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: control-center-images

View in SonarQube

sonarqube-confluent[bot] commented 7 months ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: control-center-images

View in SonarQube

sonarqube-confluent[bot] commented 7 months ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: control-center-images

View in SonarQube

VanamalaNarasimhaBhargav commented 7 months ago

Build is passing in this PR confluentinc/control-center-images/pull/90 Build failure in current PR is because semaphore not being able to pick up modified target branch.