confluentinc / cp-demo

Confluent Platform Demo including Apache Kafka, ksqlDB, Control Center, Schema Registry, Security, Schema Linking, and Cluster Linking
Apache License 2.0
38 stars 322 forks source link

DEVX-2622 & DEVX-2640: Update kstreams deps to CP versions and redact logging #377

Closed rspurgeon closed 3 years ago

rspurgeon commented 3 years ago

Description

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

Reviewer Tasks

ybyzek commented 3 years ago

@nagpavan-chilakam would you be interested to validate this PR?

nagpavan-chilakam commented 3 years ago

@ybyzek , ran a cp-demo test. I don't see the streams-demo app logging any passwords. I still see passwords logged by connect(in one instance) and ldap, which I see is out of the scope of this PR. Note: I just ran the cp-demo start script and didnt actually validate the demo other than checking if I was able to login to c3.

rspurgeon commented 3 years ago

ance) and ldap, which I see is out of the scope of this PR. Note: I just ran the cp-demo start script and didnt

Thanks @nagpavan-chilakam , yes I intend to address those in follow up PRs. They require more investigation.