search

confluentinc / cp-demo

Confluent Platform Demo including Apache Kafka, ksqlDB, Control Center, Schema Registry, Security, Schema Linking, and Cluster Linking
Apache License 2.0
38 stars 322 forks source link

fix: Dockerfile-confluenthub connector uses REPOSITORY override if defined #392

Closed andrewegel closed 3 years ago

andrewegel commented 3 years ago

This seems to be a long standing bug that I'm fixing here.

Locally tested against ECR images with minor env_files/config.env changes.

ybyzek commented 3 years ago

@andrewegel these files have been renamed in more recent branches, and this bug has been fixed, please see https://github.com/confluentinc/cp-demo/blob/6.2.1-post/Dockerfile#L19

andrewegel commented 3 years ago

OK.

andrewegel commented 3 years ago

Actually I would like to take this fix, back-porting https://github.com/confluentinc/cp-demo/pull/326 isn't clean, and isn't complete either, if REPOSITORY isn't defined, then the change wouldn't work, it needs a sane default.

ybyzek commented 3 years ago

@andrewegel when it comes to pint merge can you please limit it to this branch?

andrewegel commented 3 years ago

@andrewegel when it comes to pint merge can you please limit it to this branch?

I'll work an applicable change up through the branches. Skipping where needed.

andrewegel commented 3 years ago

Pint merged into 6.0.3-post and 6.0.4-post - Skipped thereafter as a conflict arose.