confluentinc / cp-demo

Confluent Platform Demo including Apache Kafka, ksqlDB, Control Center, Schema Registry, Security, Schema Linking, and Cluster Linking
Apache License 2.0
38 stars 322 forks source link

DEVX-2680: cp-demo/gitpod: add docs back in #399

Closed vdesabou closed 3 years ago

vdesabou commented 3 years ago

Description

https://confluentinc.atlassian.net/browse/DEVX-2680

What behavior does this PR change, and why?

Take back the docs changes from https://confluentinc.atlassian.net/browse/DEVX-2672 I've also included the changes in conf.py from docs-platform PR I'm also mentioning that C3_KSQLDB_HTTPS=true is not supported when using Gitpod

Author Validation

Building locally, the gitpod_link is resolved, see:

CleanShot 2021-10-15 at 13 08 43

See screenshots of all the changes:

CleanShot 2021-10-15 at 13 09 33

CleanShot 2021-10-15 at 13 02 33

CleanShot 2021-10-15 at 13 03 06

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

gitpod-io[bot] commented 3 years ago

vdesabou commented 3 years ago

The new gitpod link looks ok, see:

CleanShot 2021-10-18 at 14 47 45

@ybyzek Should I merge or you do it ?

joel-hamill commented 3 years ago

looks good on the live site: https://docs.confluent.io/platform/current/tutorials/cp-demo/docs/on-prem.html#setup. thanks @vdesabou