search

confluentinc / cp-demo

Confluent Platform Demo including Apache Kafka, ksqlDB, Control Center, Schema Registry, Security, Schema Linking, and Cluster Linking
Apache License 2.0
38 stars 322 forks source link

CLI-1398: Update CLI references to v2 #404

Closed brianstrauch closed 2 years ago

brianstrauch commented 3 years ago

Description

Update confluent v1 / ccloud syntax to confluent v2 syntax.

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

gitpod-io[bot] commented 3 years ago

ybyzek commented 3 years ago

@chuck-confluent is there going to be a new tools Docker image with the updated CLIs, and how will it provide the unified CLI?

ybyzek commented 3 years ago

@chuck-confluent is there going to be a new tools Docker image with the updated CLIs, and how will it provide the unified CLI?

Correction: cp-demo is no longer using training/tools image, it is now using https://hub.docker.com/r/cnfldemos/tools which is built from: https://github.com/confluentinc/cp-demo/blob/7.0.0-post/tools/Dockerfile-tools . So @brianstrauch this PR should also modify that Dockerfile and we in DevX can validate and publish the updated Docker image

ybyzek commented 3 years ago

Because cp-demo hybrid module uses ccloud-stack, this PR is blocked by https://github.com/confluentinc/examples/pull/1047 (actually they should be merged simultaneously)

brianstrauch commented 3 years ago

@brianstrauch does this issue happen on your end as well?

@ybyzek I would expect to see /usr/bin/confluent-v1 as the output for which confluent-v1, if that code snippet is from a Docker container.

ybyzek commented 3 years ago

@brianstrauch https://hub.docker.com/layers/cnfldemos/tools/0.3/images/sha256-90e9983e63d519becd20878249b0448c67f32c4381b5967620e3a3291c85347e?context=explore (tag 0.3) is now published on Docker Hub. Can you please update the docker-compose.yml file as part of the PR? https://github.com/confluentinc/cp-demo/blob/7.0.0-post/docker-compose.yml#L52

ybyzek commented 3 years ago

@brianstrauch bump on https://github.com/confluentinc/cp-demo/pull/404#discussion_r753160486 (which might be one of the last changes required to unblock script execution)

ybyzek commented 2 years ago

I have verified the CCloud portion of the demo with the new ccloud_library.sh file in https://github.com/confluentinc/examples/pull/1047